Remove Cow from InstrumentationScope #2275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Nov 5, 2024
cijothomas
reviewed
Nov 5, 2024
cijothomas
requested changes
Nov 5, 2024
Member
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
From Community Call:
- Lets keep builder as-is (i.e accept Cow.. )
- Hide fields from InstrumentationScope and offer pub getters.
stormshield-fabs
force-pushed
the
instrumentation-scope-no-cow
branch
from
9b3d790 to
7c69e5c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2275 +/- ##
=======================================
- Coverage 79.5% 79.5% -0.1%
=======================================
Files 121 121
Lines 20974 20978 +4
=======================================
+ Hits 16684 16687 +3
- Misses 4290 4291 +1 ☔ View full report in Codecov by Sentry. |
utpilla
reviewed
Nov 6, 2024
utpilla
approved these changes
Nov 6, 2024
Contributor
utpilla
left a comment
utpilla
left a comment
There was a problem hiding this comment.
Looks good with a CHANGELOG entry.
lalitb
reviewed
Nov 6, 2024
lalitb
reviewed
Nov 6, 2024
stormshield-fabs
force-pushed
the
instrumentation-scope-no-cow
branch
from
7c69e5c to
fa00c63
Compare
lalitb
approved these changes
Nov 6, 2024
cijothomas
approved these changes
Nov 6, 2024
bantonsson
pushed a commit
to bantonsson/opentelemetry-rust
that referenced
this pull request
Oct 9, 2025
Co-authored-by: Lalit Kumar Bhasin <[email protected]> Co-authored-by: Cijo Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2246
Changes
Removed the
InstrumentationScopeattributes from the public API and replaced them with getters.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes